pgsql: Code and docs review for multiple -c and -f options in psql. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Code and docs review for multiple -c and -f options in psql.
Date
Msg-id E1a8Cgn-0006xb-IX@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Code and docs review for multiple -c and -f options in psql.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-committers
Code and docs review for multiple -c and -f options in psql.

Commit d5563d7df94488bf drew complaints from Coverity, which quite
correctly complained that one copy of each -c or -f string was being
leaked.  What's more, simple_action_list_append was allocating enough space
for still a third copy of each string as part of the SimpleActionListCell,
even though that coding method had been superseded by a separate strdup
operation.  There were some other minor coding infelicities too.  The
documentation needed more work as well, eg it forgot to explain that -c
causes psql not to accept any interactive input.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/fcbbf82d2b6caf7b156f2ec35b322e23caf1e99e

Modified Files
--------------
doc/src/sgml/ref/psql-ref.sgml |  140 +++++++++++++++++++++++-----------------
src/bin/psql/startup.c         |   93 ++++++++++++--------------
2 files changed, 121 insertions(+), 112 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Fix bug leading to restoring unlogged relations from empty files
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Code and docs review for multiple -c and -f options in psql.