pgsql: Avoid odd portability problem in TestLib.pm's slurp_file functio - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid odd portability problem in TestLib.pm's slurp_file functio
Date
Msg-id E1a6QHE-0001wQ-Ii@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid odd portability problem in TestLib.pm's slurp_file function.

For unclear reasons, this function doesn't always read the expected data
in some old Perl versions.  Rewriting it to avoid use of ARGV seems to
dodge the problem, and this version is clearer anyway if you ask me.

In passing, also improve error message in adjacent append_to_file function.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/938d797b84467ebbaed432da72d1d7f7bb266110

Modified Files
--------------
src/test/perl/TestLib.pm |   11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Avoid odd portability problem in TestLib.pm's slurp_file functio
Next
From: Tom Lane
Date:
Subject: pgsql: Make failure to open psql's --log-file fatal.