pgsql: Fix potential platform dependence in gist regression test. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix potential platform dependence in gist regression test.
Date
Msg-id E1ZUGO2-0007H7-DR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix potential platform dependence in gist regression test.

The results of the KNN-search test cases were indeterminate, as they asked
the system to sort pairs of points that are exactly equidistant from the
query reference point.  It's a bit surprising that we've seen no
platform-specific failures from this in the buildfarm.  Perhaps IEEE-float
math is well enough standardized that no such failures will ever occur on
supported platforms ... but since this entire regression test has yet to be
shipped in any non-alpha release, that seems like an unduly optimistic
assumption.  Tweak the queries so that the correct output is uniquely
defined.

(The other queries in this test are also underdetermined; but it looks like
they are regurgitating index rows in insertion order, so for the moment
assume that that behavior is stable enough.)

Per Greg Stark's experiments with VAX.  Back-patch to 9.5 where this test
script was introduced.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b8c91352a2e168e1c24cc33862a0d95f13fd0957

Modified Files
--------------
src/test/regress/expected/gist.out |   16 ++++++++--------
src/test/regress/sql/gist.sql      |    8 ++++----
2 files changed, 12 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Tweak wording of syntax error messages about bad CONTINUE/EXIT s
Next
From: Tom Lane
Date:
Subject: pgsql: Fix potential platform dependence in gist regression test.