pgsql: Fix bug in calculations of hash join buckets. - Mailing list pgsql-committers

From Kevin Grittner
Subject pgsql: Fix bug in calculations of hash join buckets.
Date
Msg-id E1ZS3UH-0003hg-3o@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bug in calculations of hash join buckets.

Commit 8cce08f168481c5fc5be4e7e29b968e314f1b41e used a left-shift
on a literal of 1 that could (in large allocations) be shifted by
31 or more bits.  This was assigned to a local variable that was
already declared to be a long to protect against overruns of int,
but the literal in this shift needs to be declared long to allow it
to work correctly in some compilers.

Backpatch to 9.5, where the bug was introduced.

Report and patch by KaiGai Kohei, slighly modified based on
discussion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1cac8c98201cb0ed1a3592cf355a2670d3771689

Modified Files
--------------
src/backend/executor/nodeHash.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix a few bogus statement type names in plpgsql error messages.
Next
From: Kevin Grittner
Date:
Subject: pgsql: Fix bug in calculations of hash join buckets.