pgsql: Improve configure test for the sse4.2 crc instruction. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Improve configure test for the sse4.2 crc instruction.
Date
Msg-id E1ZRGpt-0006VV-Ek@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve configure test for the sse4.2 crc instruction.

With optimizations enabled at least one compiler, clang 3.7, optimized
away the crc intrinsics knowing that the result went on unused and has
no side effects. That can trigger errors in code generation when the
intrinsic is used, as we chose to use the intrinsics without any
additional compiler flag. Return the computed value to prevent that.

With some more pedantic warning flags (-Wold-style-definition) the
configure test failed to recognize the existence of _mm_crc32_u*
intrinsics due to an independent warning in the test because the test
turned on -Werror, but that's not actually needed here.

Discussion: 20150814092039.GH4955@awork2.anarazel.de
Backpatch: 9.5, where the use of crc intrinsics was integrated.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6cf72879e944f32b5b8232541cccd575de797fa4

Modified Files
--------------
config/c-compiler.m4 |    7 +++----
configure            |   10 ++++------
2 files changed, 7 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Improve configure test for the sse4.2 crc instruction.
Next
From: Andres Freund
Date:
Subject: pgsql: docs: Fix "typo" introduced in 3f811c2d.