pgsql: Micro optimize LWLockAttemptLock() a bit. - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Micro optimize LWLockAttemptLock() a bit.
Date
Msg-id E1ZLwTm-0005Nv-GR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Micro optimize LWLockAttemptLock() a bit.

LWLockAttemptLock pointlessly read the lock's state in every loop
iteration, even though pg_atomic_compare_exchange_u32() returns the old
value. Instead do that only once before the loop iteration.

Additionally there's no need to have the expected_state variable,
old_state mostly had the same value anyway.

Noticed-By: Heikki Linnakangas
Backpatch: 9.5, no reason to let the branches diverge at this point

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9074e41dbd41bc45ef79aeac1b6496bf087509a7

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c |   20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Micro optimize LWLockAttemptLock() a bit.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix race condition that lead to WALInsertLock deadlock with comm