pgsql: Fix handling of all-zero pages in SP-GiST vacuum. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix handling of all-zero pages in SP-GiST vacuum.
Date
Msg-id E1ZJk7X-0001dN-CO@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix handling of all-zero pages in SP-GiST vacuum.

SP-GiST initialized an all-zeros page at vacuum, but that was not
WAL-logged, which is not safe. You might get a torn page write, when it gets
flushed to disk, and end-up with a half-initialized index page. To fix,
leave it in the all-zeros state, and add it to the FSM. It will be
initialized when reused. Also don't set the page-deleted flag when recycling
an empty page. That was also not WAL-logged, and a torn write of that would
cause the page to have an invalid checksum.

Backpatch to 9.2, where SP-GiST indexes were added.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2fa8ba34804211714a6e0a7fcf5512423c77f8dd

Modified Files
--------------
src/backend/access/spgist/spgvacuum.c |   27 ++++++++-------------------
src/include/access/spgist_private.h   |    4 ++--
2 files changed, 10 insertions(+), 21 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Reuse all-zero pages in GIN.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Avoid calling PageGetSpecialPointer() on an all-zeros page.