pgsql: Fix test_decoding's handling of nonexistant columns in old tuple - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Fix test_decoding's handling of nonexistant columns in old tuple
Date
Msg-id E1Z8tox-0006Tg-1y@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix test_decoding's handling of nonexistant columns in old tuple versions.

test_decoding used fastgetattr() to extract column values. That's wrong
when decoding updates and deletes if a table's replica identity is set
to FULL and new columns have been added since the old version of the
tuple was created. Due to the lack of a crosscheck with the datum's
natts values an invalid value will be output, leading to errors or
worse.

Bug: #13470
Reported-By: Krzysztof Kotlarski
Discussion: 20150626100333.3874.90852@wrigleys.postgresql.org

Backpatch to 9.4, where the feature, including the bug, was added.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/d47a1136e441cebe7ae7fe72d70eb8ce278d5cd6

Modified Files
--------------
contrib/test_decoding/expected/ddl.out |   14 ++++++++++++--
contrib/test_decoding/sql/ddl.sql      |    4 ++++
contrib/test_decoding/test_decoding.c  |    2 +-
3 files changed, 17 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix test_decoding's handling of nonexistant columns in old tuple
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid passing NULL to memcmp() in lookups of zero-argument funct