pgsql: Fix rare core dump in BackendIdGetTransactionIds(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix rare core dump in BackendIdGetTransactionIds().
Date
Msg-id E1Ycd8A-0006dl-En@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix rare core dump in BackendIdGetTransactionIds().

BackendIdGetTransactionIds() neglected the possibility that the PROC
pointer in a ProcState array entry is null.  In current usage, this could
only crash if the other backend had exited since pgstat_read_current_status
saw it as active, which is a pretty narrow window.  But it's reachable in
the field, per bug #12918 from Vladimir Borodin.

Back-patch to 9.4 where the faulty code was introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2897e069c1f4309a237a1fa4bf5d2fcd9c4b9868

Modified Files
--------------
src/backend/storage/ipc/sinvaladt.c |   15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Centralize definition of integer limits.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix rare core dump in BackendIdGetTransactionIds().