pgsql: Fix volatile-safety issue in dblink's materializeQueryResult(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().
Date
Msg-id E1YFq6f-0000tB-F3@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix volatile-safety issue in dblink's materializeQueryResult().

Some fields of the sinfo struct are modified within PG_TRY and then
referenced within PG_CATCH, so as with recent patch to async.c, "volatile"
is necessary for strict POSIX compliance; and that propagates to a couple
of subroutines as well as materializeQueryResult() itself.  I think the
risk of actual issues here is probably higher than in async.c, because
storeQueryResult() is likely to get inlined into materializeQueryResult(),
leaving the compiler free to conclude that its stores into sinfo fields are
dead code.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/e50e2e08232426f235a7dd7be078cd617be9202a

Modified Files
--------------
contrib/dblink/dblink.c |   12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().
Next
From: Tom Lane
Date:
Subject: pgsql: Fix volatile-safety issue in dblink's materializeQueryResult().