pgsql: MinGW: Include .dll extension in .def file LIBRARY commands. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: MinGW: Include .dll extension in .def file LIBRARY commands.
Date
Msg-id E1XiuDH-0001CU-KR@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
MinGW: Include .dll extension in .def file LIBRARY commands.

Newer toolchains append the extension implicitly if missing, but
buildfarm member narwhal (gcc 3.4.2, ld 2.15.91 20040904) does not.
This affects most core libraries having an exports.txt file, namely
libpq and the ECPG support libraries.  On Windows Server 2003, Windows
API functions that load and unload DLLs internally will mistakenly
unload a libpq whose DLL header reports "LIBPQ" instead of "LIBPQ.dll".
When, subsequently, control would return to libpq, the backend crashes.
Back-patch to 9.4, like commit 846e91e0223cf9f2821c3ad4dfffffbb929cb027.
Before that commit, we used a different linking technique that yielded
"libpq.dll" in the DLL header.

Commit 53566fc0940cf557416b13252df57350a4511ce4 worked around this by
eliminating a call to a function that loads and unloads DLLs internally.
That commit is no longer necessary for correctness, but its improving
consistency with the MSVC build remains valid.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c68bff644357c743d14065b8085dbb04d1505c72

Modified Files
--------------
src/Makefile.shlib |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: MinGW: Include .dll extension in .def file LIBRARY commands.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Remove unnecessary assignment.