pgsql: Work around Windows locale name with non-ASCII character. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Work around Windows locale name with non-ASCII character.
Date
Msg-id E1XhjKc-0003Zi-98@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Work around Windows locale name with non-ASCII character.

Windows has one a locale whose name contains a non-ASCII character:
"Norwegian (Bokmål)" (that's an 'a' with a ring on top). That causes
trouble; when passing it setlocale(), it's not clear what encoding the
argument should be in. Another problem is that the locale name is stored in
pg_database catalog table, and the encoding used there depends on what
server encoding happens to be in use when the database is created. For
example, if you issue the CREATE DATABASE when connected to a UTF-8
database, the locale name is stored in pg_database in UTF-8. As long as all
locale names are pure ASCII, that's not a problem.

To work around that, map the troublesome locale name to a pure-ASCII alias
of the same locale, "norwegian-bokmal".

Now, this doesn't change the existing values that are already in
pg_database and in postgresql.conf. Old clusters will need to be fixed
manually. Instructions for that need to be put in the release notes.

This fixes bug #11431 reported by Alon Siman-Tov. Backpatch to 9.2;
backpatching further would require more work than seems worth it.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c3c2d986977b60e3db26601d44ab029ef99156cc

Modified Files
--------------
src/port/win32setlocale.c |  158 ++++++++++++++++++++++++++++++++-------------
1 file changed, 114 insertions(+), 44 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Work around Windows locale name with non-ASCII character.
Next
From: Andres Freund
Date:
Subject: pgsql: Add native compiler and memory barriers for solaris studio.