pgsql: Don't duplicate log_checkpoint messages for both of restart and - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Don't duplicate log_checkpoint messages for both of restart and
Date
Msg-id E1XgLzK-00033z-IY@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't duplicate log_checkpoint messages for both of restart and checkpoints.

The duplication originated in cdd46c765, where restartpoints were
introduced.

In LogCheckpointStart's case the duplication actually lead to the
compiler's format string checking not to be effective because the
format string wasn't constant.

Arguably these messages shouldn't be elog(), but ereport() style
messages. That'd even allow to translate the messages... But as
there's more mistakes of that kind in surrounding code, it seems
better to change that separately.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/5e5b65f359b7a12c05708585a8e6cd4d80ca2652

Modified Files
--------------
src/backend/access/transam/xlog.c |   62 +++++++++++--------------------------
1 file changed, 18 insertions(+), 44 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Renumber CHECKPOINT_* flags.
Next
From: Noah Misch
Date:
Subject: Re: pgsql: doc: restrictions on alter database moving default tablespace