pgsql: Add rmgr callback to name xlog record types for display purposes - Mailing list pgsql-committers

From Andres Freund
Subject pgsql: Add rmgr callback to name xlog record types for display purposes
Date
Msg-id E1XUzV2-0002mn-JB@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add rmgr callback to name xlog record types for display purposes.

This is primarily useful for the upcoming pg_xlogdump --stats feature,
but also allows to remove some duplicated code in the rmgr_desc
routines.

Due to the separation and harmonization, the output of dipsplayed
records changes somewhat. But since this isn't enduser oriented
content that's ok.

It's potentially desirable to further change pg_xlogdump's display of
records. It previously wasn't possible to show the record type
separately from the description forcing it to be in the last
column. But that's better done in a separate commit.

Author: Abhijit Menon-Sen, slightly editorialized by me
Reviewed-By: Álvaro Herrera, Andres Freund, and Heikki Linnakangas
Discussion: 20140604104716.GA3989@toroid.org

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/728f152e07f998d2cb4fe5f24ec8da2c3bda98f2

Modified Files
--------------
contrib/pg_xlogdump/pg_xlogdump.c         |    5 +-
contrib/pg_xlogdump/rmgrdesc.c            |    4 +-
contrib/pg_xlogdump/rmgrdesc.h            |    1 +
src/backend/access/rmgrdesc/clogdesc.c    |   27 ++++---
src/backend/access/rmgrdesc/dbasedesc.c   |   24 +++++-
src/backend/access/rmgrdesc/gindesc.c     |   54 ++++++++++---
src/backend/access/rmgrdesc/gistdesc.c    |   25 +++++-
src/backend/access/rmgrdesc/hashdesc.c    |    6 ++
src/backend/access/rmgrdesc/heapdesc.c    |  123 ++++++++++++++++++++--------
src/backend/access/rmgrdesc/mxactdesc.c   |   37 ++++++---
src/backend/access/rmgrdesc/nbtdesc.c     |  124 +++++++++++++++--------------
src/backend/access/rmgrdesc/relmapdesc.c  |   19 ++++-
src/backend/access/rmgrdesc/seqdesc.c     |   21 +++--
src/backend/access/rmgrdesc/smgrdesc.c    |   25 ++++--
src/backend/access/rmgrdesc/spgdesc.c     |   57 ++++++++++---
src/backend/access/rmgrdesc/standbydesc.c |   27 +++++--
src/backend/access/rmgrdesc/tblspcdesc.c  |   25 ++++--
src/backend/access/rmgrdesc/xactdesc.c    |   48 ++++++++---
src/backend/access/rmgrdesc/xlogdesc.c    |   72 ++++++++++++-----
src/backend/access/transam/rmgr.c         |    4 +-
src/backend/access/transam/xlog.c         |   30 +++++--
src/include/access/clog.h                 |    1 +
src/include/access/gin.h                  |    1 +
src/include/access/gist_private.h         |    1 +
src/include/access/hash.h                 |    1 +
src/include/access/heapam_xlog.h          |    2 +
src/include/access/multixact.h            |    1 +
src/include/access/nbtree.h               |    1 +
src/include/access/rmgr.h                 |    2 +-
src/include/access/rmgrlist.h             |   34 ++++----
src/include/access/spgist.h               |    1 +
src/include/access/xact.h                 |    1 +
src/include/access/xlog.h                 |    1 +
src/include/access/xlog_internal.h        |    9 +++
src/include/catalog/storage_xlog.h        |    1 +
src/include/commands/dbcommands.h         |    1 +
src/include/commands/sequence.h           |    1 +
src/include/commands/tablespace.h         |    1 +
src/include/storage/standby.h             |    1 +
src/include/utils/relmapper.h             |    1 +
40 files changed, 587 insertions(+), 233 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Add the capability to display summary statistics to pg_xlogdump.
Next
From: Andres Freund
Date:
Subject: pgsql: Avoid 'clobbered by longjmp' warning in psql/copy.c.