pgsql: Remove some useless code in the configure script. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove some useless code in the configure script.
Date
Msg-id E1X25y5-0006sq-6m@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove some useless code in the configure script.

Almost ten years ago, commit e48322a6d6cfce1ec52ab303441df329ddbc04d1 broke
the logic in ACX_PTHREAD by looping through all the possible flags rather
than stopping with the first one that would work.  This meant that
$acx_pthread_ok was no longer meaningful after the loop; it would usually
be "no", whether or not we'd found working thread flags.  The reason nobody
noticed is that Postgres doesn't actually use any of the symbols set up
by the code after the loop.  Rather than complicate things some more to
make it work as designed, let's just remove all that dead code, and thereby
save a few cycles in each configure run.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2e8ce9ae46d15b2bfd34c2d53193da9858d3471a

Modified Files
--------------
config/acx_pthread.m4         |   77 +++------------------
configure                     |  152 ++---------------------------------------
configure.in                  |    9 ---
src/include/pg_config.h.in    |    7 --
src/include/pg_config.h.win32 |    7 --
5 files changed, 16 insertions(+), 236 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve handling of OOM score adjustment in sample Linux start s
Next
From: Tom Lane
Date:
Subject: pgsql: Refactor CREATE/ALTER DATABASE syntax so options need not be key