pgsql: Back-patch "Fix EquivalenceClass processing for nested append re - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Back-patch "Fix EquivalenceClass processing for nested append re
Date
Msg-id E1X0Dgi-0000sZ-Ou@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Back-patch "Fix EquivalenceClass processing for nested append relations".

When we committed a87c729153e372f3731689a7be007bc2b53f1410, we somehow
failed to notice that it didn't merely improve plan quality for expression
indexes; there were very closely related cases that failed outright with
"could not find pathkey item to sort".  The failing cases seem to be those
where the planner was already capable of selecting a MergeAppend plan,
and there was inheritance involved: the lack of appropriate eclass child
members would prevent prepare_sort_from_pathkeys() from succeeding on the
MergeAppend's child plan nodes for inheritance child tables.

Accordingly, back-patch into 9.1 through 9.3, along with an extra
regression test case covering the problem.

Per trouble report from Michael Glaesemann.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/555d0b2000e33fd1ad2721015996a66c43bbb3cd

Modified Files
--------------
src/backend/optimizer/path/allpaths.c   |   20 ++++++++++++++++----
src/backend/optimizer/path/equivclass.c |   12 ++++++++----
src/backend/optimizer/plan/createplan.c |    2 +-
src/test/regress/expected/union.out     |   28 ++++++++++++++++++++++++++++
src/test/regress/sql/union.sql          |   18 ++++++++++++++++++
5 files changed, 71 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Do all-visible handling in lazy_vacuum_page() outside its critic
Next
From: Tom Lane
Date:
Subject: pgsql: Forward-patch regression test for "could not find pathkey item t