pgsql: Fix backup-block numbering in redo of b-tree split. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Fix backup-block numbering in redo of b-tree split.
Date
Msg-id E1WmKpi-0002iN-1k@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix backup-block numbering in redo of b-tree split.

I got the backup block numbers off-by-one in the commit that changed the
way incomplete-splits are handled. I blame the comments, which said
"backup block 1" and "backup block 2", even though the backup blocks
are numbered starting from 0, in the macros and functions used in replay.
Fix the comments and the code.

Per Jeff Janes' bug report about corruption caused by torn page writes.
The incorrect code is new in git master, but backpatch the comment change
down to 9.0, where the numbering in the redo-side macros  was changed.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/c91a9b5a285e20e54cf90f3660ce51ce3a5c2ef4

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c |   12 ++++++------
src/backend/access/nbtree/nbtxlog.c   |    8 ++++----
2 files changed, 10 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Use 0-based numbering in comments about backup blocks.
Next
From: Heikki Linnakangas
Date:
Subject: pgsql: Use 0-based numbering in comments about backup blocks.