pgsql: In initdb, ensure stdout/stderr buffering behavior is what we ex - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: In initdb, ensure stdout/stderr buffering behavior is what we ex
Date
Msg-id E1WkkFq-0000bF-Sj@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
In initdb, ensure stdout/stderr buffering behavior is what we expect.

Since this program may print to either stdout or stderr, the relative
ordering of its messages depends on the buffering behavior of those files.
Force stdout to be line-buffered and stderr to be unbuffered, ensuring
that the behavior will match standard Unix interactive behavior, even
when stdout and stderr are rerouted to a file.

Per complaint from Tomas Vondra.  The particular case he pointed out is
new in HEAD, but issues of the same sort could arise in any branch with
other error messages, so back-patch to all branches.

I'm unsure whether we might not want to do this in other client programs
as well.  For the moment, just fix initdb.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2dc4f011fd61501cce507be78c39a2677690d44b

Modified Files
--------------
src/bin/initdb/initdb.c |    9 +++++++++
1 file changed, 9 insertions(+)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: Fix version check for pg_upgrade line type crosscheck.
Next
From: Tom Lane
Date:
Subject: pgsql: In initdb, ensure stdout/stderr buffering behavior is what we ex