pgsql: hash_any returns Datum, not uint32 (and definitely not "int"). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: hash_any returns Datum, not uint32 (and definitely not "int").
Date
Msg-id E1WhrvW-0001uu-Q8@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
hash_any returns Datum, not uint32 (and definitely not "int").

The coding in JsonbHashScalarValue might have accidentally failed to fail
given current representational choices, but the key word there would be
"accidental".  Insert the appropriate datatype conversion macro.  And
use the right conversion macro for hash_numeric's result, too.

In passing make the code a bit cleaner and less repetitive by factoring
out the xor step from the switch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2c22afaa4e29cbd773bae3f043a941f82ff30e2d

Modified Files
--------------
src/backend/utils/adt/jsonb_util.c |   43 +++++++++++++++++++-----------------
1 file changed, 23 insertions(+), 20 deletions(-)


pgsql-committers by date:

Previous
From: Jeff Davis
Date:
Subject: pgsql: Improve comment for tricky aspect of index-only scans.
Next
From: Jeff Davis
Date:
Subject: pgsql: Fix interval test, which was broken for floating-point timestamp