pgsql: Fix pg_type.typlen for newly-revived line type. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix pg_type.typlen for newly-revived line type.
Date
Msg-id E1WhMq0-0004EO-BQ@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Fix pg_type.typlen for newly-revived line type.  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-committers
Fix pg_type.typlen for newly-revived line type.

Commit 261c7d4b653bc3e44c31fd456d94f292caa50d8f removed the "m" field
from struct LINE, but neglected to make pg_type.h's idea of the type's
size match.  This resulted in reading past the end of palloc'd LINE
values when inserting them into tuples etc.  In principle that could
cause a SIGSEGV, though the odds of detectable problems seem low.

Bump catversion since this makes an incompatible on-disk format change.
Note that if the line type had been in use in the field, this would
break pg_upgrade'ability of databases containing line values; but
it seems unlikely that there are any (they'd have had to be compiled
with -DENABLE_LINE_TYPE).

Spotted by Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3727afafeef69088456acc3f6257360315220a20

Modified Files
--------------
src/include/catalog/catversion.h |    2 +-
src/include/catalog/pg_type.h    |    2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Revive line type
Next
From: Alvaro Herrera
Date:
Subject: Re: pgsql: Fix pg_type.typlen for newly-revived line type.