pgsql: Fix unportable shell-script syntax in pg_upgrade's test.sh. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix unportable shell-script syntax in pg_upgrade's test.sh.
Date
Msg-id E1WPMmF-0003I7-R6@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix unportable shell-script syntax in pg_upgrade's test.sh.

I discovered the hard way that on some old shells, the locution
    FOO=""   unset FOO
does not behave the same as
    FOO="";  unset FOO
and in fact leaves FOO set to an empty string.  test.sh was inconsistently
spelling it different ways on adjacent lines.

This got broken relatively recently, in commit c737a2e56, so the lack of
field reports to date doesn't represent a lot of evidence that the problem
is rare.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0268d21e5d3c732bf5543d68a6d870e4eee7e673

Modified Files
--------------
contrib/pg_upgrade/test.sh |    4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix unportable shell-script syntax in pg_upgrade's test.sh.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Translation updates