pgsql: Remove dependency on database encoding in citext regression test - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove dependency on database encoding in citext regression test
Date
Msg-id E1WJ76c-000519-Ey@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dependency on database encoding in citext regression test.

Testing convert_to(..., 'ISO-8859-1') fails if there isn't a conversion
function available from the database encoding to ISO-8859-1.  This has
been broken since day one, but the breakage was hidden by
pg_do_encoding_conversion's failure to complain, up till commit
49c817eab78c6f0ce8c3bf46766b73d6cf3190b7.

Since the data being converted in this test is plain ASCII, no actual
conversion need happen (and if it did, it would prove little about citext
anyway).  So that we still have some code coverage of the convert() family
of functions, let's switch to using convert_from, with SQL_ASCII as the
specified source encoding.  Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1161d895d826950cbb736e5872935f3f53cc2e27

Modified Files
--------------
contrib/citext/expected/citext.out   |    2 +-
contrib/citext/expected/citext_1.out |    2 +-
contrib/citext/sql/citext.sql        |    2 +-
3 files changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Fix WAL replay of locking an updated tuple
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Allow BASE_BACKUP to be throttled