pgsql: Fix portability issue in ordered-set patch. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix portability issue in ordered-set patch.
Date
Msg-id E1VvGjF-0004k1-4f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix portability issue in ordered-set patch.

Overly compact coding in makeOrderedSetArgs() led to a platform dependency:
if the compiler chose to execute the subexpressions in the wrong order,
list_length() might get applied to an already-modified List, giving a
value we didn't want.  Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cf63c641cae2063a0442d73d49af295301cec61b

Modified Files
--------------
src/backend/parser/gram.y |    6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Support ordered-set (WITHIN GROUP) aggregates.
Next
From: Robert Haas
Date:
Subject: pgsql: Revise documentation for new freezing method.