pgsql: Allow on-detach callbacks for dynamic shared memory segments. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Allow on-detach callbacks for dynamic shared memory segments.
Date
Msg-id E1VtLtI-0004MU-1h@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Allow on-detach callbacks for dynamic shared memory segments.

Just as backends must clean up their shared memory state (releasing
lwlocks, buffer pins, etc.) before exiting, they must also perform
any similar cleanups related to dynamic shared memory segments they
have mapped before unmapping those segments.  So add a mechanism to
ensure that.

Existing on_shmem_exit hooks include both "user level" cleanup such
as transaction abort and removal of leftover temporary relations and
also "low level" cleanup that forcibly released leftover shared
memory resources.  On-detach callbacks should run after the first
group but before the second group, so create a new before_shmem_exit
function for registering the early callbacks and keep on_shmem_exit
for the regular callbacks.  (An earlier draft of this patch added an
additional argument to on_shmem_exit, but that had a much larger
footprint and probably a substantially higher risk of breaking third
party code for no real gain.)

Patch by me, reviewed by KaiGai Kohei and Andres Freund.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/001a573a2011d605f2a6e10aee9996de8581d099

Modified Files
--------------
src/backend/bootstrap/bootstrap.c |    4 +-
src/backend/catalog/namespace.c   |    2 +-
src/backend/commands/async.c      |    2 +-
src/backend/storage/ipc/dsm.c     |   78 ++++++++++++++++++++++--
src/backend/storage/ipc/ipc.c     |  118 +++++++++++++++++++++++++++++--------
src/backend/utils/init/postinit.c |   15 +++--
src/include/storage/dsm.h         |   10 +++-
src/include/storage/ipc.h         |    9 +--
8 files changed, 192 insertions(+), 46 deletions(-)


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: Fix incorrect error message reported for non-existent users
Next
From: Robert Haas
Date:
Subject: pgsql: Fix compiler warning.