pgsql: Tweak placement of explicit ANALYZE commands in the regression t - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Tweak placement of explicit ANALYZE commands in the regression t
Date
Msg-id E1Vqq64-0000vm-6R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tweak placement of explicit ANALYZE commands in the regression tests.

Make the COPY test, which loads most of the large static tables used in
the tests, also explicitly ANALYZE those tables.  This allows us to get
rid of various ad-hoc, and rather redundant, ANALYZE commands that had
gotten stuck into various test scripts over time to ensure we got
consistent plan choices.  (We could have done a database-wide ANALYZE,
but that would cause stats to get attached to the small static tables
too, which results in plan changes compared to the historical behavior.
I'm not sure that's a good idea, so not going that far for now.)

Back-patch to 9.0, since 9.0 and 9.1 are currently sometimes failing
regression tests for lack of an "ANALYZE tenk1" in the subselect test.
There's no need for this in 8.4 since we didn't print any plans back
then.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9c9a1f2ebb00f96f1164f01006ab9861b36f1ab1

Modified Files
--------------
src/test/regress/expected/aggregates.out   |    1 -
src/test/regress/expected/alter_table.out  |    1 -
src/test/regress/expected/arrays.out       |    1 -
src/test/regress/expected/create_index.out |    2 +-
src/test/regress/expected/join.out         |    1 -
src/test/regress/input/copy.source         |   25 +++++++++++++++++++++++++
src/test/regress/output/copy.source        |   23 +++++++++++++++++++++++
src/test/regress/sql/aggregates.sql        |    1 -
src/test/regress/sql/alter_table.sql       |    1 -
src/test/regress/sql/arrays.sql            |    2 --
src/test/regress/sql/create_index.sql      |    2 +-
src/test/regress/sql/join.sql              |    2 --
12 files changed, 50 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Under wal_level=logical, when saving old tuples, always save OID
Next
From: Tom Lane
Date:
Subject: pgsql: Tweak placement of explicit ANALYZE commands in the regression t