pgsql: Don't TransactionIdDidAbort in HeapTupleGetUpdateXid - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Don't TransactionIdDidAbort in HeapTupleGetUpdateXid
Date
Msg-id E1VmZ0b-0008H9-4m@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't TransactionIdDidAbort in HeapTupleGetUpdateXid

It is dangerous to do so, because some code expects to be able to see what's
the true Xmax even if it is aborted (particularly while traversing HOT
chains).  So don't do it, and instead rely on the callers to verify for
abortedness, if necessary.

Several race conditions and bugs fixed in the process.  One isolation test
changes the expected output due to these.

This also reverts commit c235a6a589b, which is no longer necessary.

Backpatch to 9.3, where this function was introduced.

Andres Freund

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1ce150b7bb14105ddc190c5f1acf2ae1a9b2854a

Modified Files
--------------
src/backend/access/heap/heapam.c                   |   21 +++--
src/backend/access/heap/pruneheap.c                |   22 ++---
src/backend/utils/time/tqual.c                     |   93 +++++++++++---------
.../isolation/expected/delete-abort-savept.out     |   13 +--
4 files changed, 75 insertions(+), 74 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix assorted issues in pg_ctl's pgwin32_CommandLine().
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Truncate pg_multixact/'s contents during crash recovery