pgsql: Don't try to set InvalidXid as page pruning hint - Mailing list pgsql-committers

Don't try to set InvalidXid as page pruning hint

If a transaction updates/deletes a tuple just before aborting, and a
concurrent transaction tries to prune the page concurrently, the pruner
may see HeapTupleSatisfiesVacuum return HEAPTUPLE_DELETE_IN_PROGRESS,
but a later call to HeapTupleGetUpdateXid() return InvalidXid.  This
would cause an assertion failure in development builds, but would be
otherwise Mostly Harmless.

Fix by checking whether the updater Xid is valid before trying to apply
it as page prune point.

Reported by Andres in 20131124000203.GA4403@alap2.anarazel.de

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/4ed0640e5c356e0935c3a057de7361fc444c0056

Modified Files
--------------
src/backend/access/heap/pruneheap.c |   21 +++++++++++++++------
1 file changed, 15 insertions(+), 6 deletions(-)