pgAdmin III commit: Improved the debugger to work better with PPAS <= 9 - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject pgAdmin III commit: Improved the debugger to work better with PPAS <= 9
Date
Msg-id E1Vb8UL-0004ts-Mu@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Improved the debugger to work better with PPAS <= 9.2

Resolved the issues listed below:
- Function/Procedure (plpgsql/edb-spl) execution completed with an error - "no
  target for SPL-style OUT parameter" (PPAS <= 9.2)
  Invoke the target (procedure/function) with the value explicitly, instead of
  using the PQexecParams (a libpq API) due to a bug in PPAS <= 9.2
- A function with the OUT parameter and other VARIADIC parameter is not
  debuggable on PPAS/PostgreSQL
  Fixed it by using the sequence number properly for IN/INOUT parameters and
  ignoring them for the OUT parameter
- On execution completion an edb-spl function was showing result value with
  PPAS <= 9.2
  With the latest redesing of debugger, we were able to show the result
  properly for PPAS >= 9.3. But - for earlier version, we will have to use the
  anonymous block with edb-spl. And, that forced us to fetch the result as
  message and the result will be shown in the dbms-message window, instead of
  result window.
- Marker, showing current position of the execution in debugger, was offset by
  1 for PG/PPAS <= 9.0

Branch
------
REL-1_18_0_PATCHES

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ecab5e3a3cf727d311a8ad7662a0b7980a28b6ab

Modified Files
--------------
CHANGELOG                                |    1 +
pgadmin/debugger/dbgController.cpp       |    8 +-
pgadmin/debugger/dbgEvents.cpp           |    2 +-
pgadmin/debugger/dbgTargetInfo.cpp       |  119 ++++++++++++++++--------------
pgadmin/debugger/dlgDirectDbg.cpp        |    2 +-
pgadmin/include/debugger/dbgController.h |    3 +
6 files changed, 75 insertions(+), 60 deletions(-)


pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgadmin-support] pgAdmin 1.18.0 + slony-I 2.2.0 + PG 9.3
Next
From: Ashesh Vashi
Date:
Subject: pgAdmin III commit: Improved the debugger to work better with PPAS <= 9