pgsql: Clean up pg_basebackup libpq usage - Mailing list pgsql-committers

From Stephen Frost
Subject pgsql: Clean up pg_basebackup libpq usage
Date
Msg-id E1Uykmo-0008SG-Lh@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Clean up pg_basebackup libpq usage

When using libpq, it's generally preferrable to just use the strings
which are in the PQ structures instead of copying them out, so do
that instead in BaseBackup(), eliminating the strcpy()'s used there.

Also, in ReceiveAndUnpackTarFile(), check the string length for the
directory returned by the server for the tablespace path.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/2f397a08de49e28e3430ff7278f4648757dea2a3

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c |   17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: vacuumlo: Use a cursor to limit client-side memory usage.
Next
From: Robert Haas
Date:
Subject: pgsql: Regression tests for LOCK TABLE.