pgsql: Be sure to close() file descriptor on error case - Mailing list pgsql-committers

From Stephen Frost
Subject pgsql: Be sure to close() file descriptor on error case
Date
Msg-id E1UyTst-0000HB-Fc@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Be sure to close() file descriptor on error case

In receivelog.c:writeTimeLineHistoryFile(), we were not properly
closing the open'd file descriptor in error cases.  While this
wouldn't matter much if we were about to exit due to such an
error, that's not the case with pg_receivexlog as it can be a
long-running process and these errors are non-fatal.

This resource leak was found by the Coverity scanner.

Back-patch to 9.3 where this issue first appeared.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cec62efd0e551a56635b47ea4185ec27a6840de7

Modified Files
--------------
src/bin/pg_basebackup/receivelog.c |    2 ++
1 file changed, 2 insertions(+)


pgsql-committers by date:

Previous
From: Stephen Frost
Date:
Subject: pgsql: Ensure 64bit arithmetic when calculating tapeSpace
Next
From: Stephen Frost
Date:
Subject: pgsql: Be sure to close() file descriptor on error case