Attempt to fix error recovery in COPY BOTH mode.
Previously, libpq and the backend had opposite ideas about whether
it was necessary for the client to send a CopyDone message after
receiving an ErrorResponse, making it impossible to cleanly exit
COPY BOTH mode. Fix libpq so that works correctly, adopting the
backend's notion that an ErrorResponse kills the copy in both
directions.
Adjust receivelog.c to avoid a degradation in the quality of the
resulting error messages. libpqwalreceiver.c is already doing
the right thing, so no adjustment needed there.
Add an explicit statement to the documentation explaining how
this part of the protocol is supposed to work, in the hopes of
avoiding future confusion in this area.
Since the consequences of all this confusion are very limited,
especially in the back-branches where no client ever attempts
to exit COPY BOTH mode without closing the connection entirely,
no back-patch.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/91fa8532f4053468acc08534a6aac516ccde47b7
Modified Files
--------------
doc/src/sgml/protocol.sgml | 9 +++++-
src/bin/pg_basebackup/receivelog.c | 47 ++++++++++++++++++++--------------
src/interfaces/libpq/fe-protocol3.c | 31 ++++++++++++-----------
3 files changed, 51 insertions(+), 36 deletions(-)
