pgsql: Fix to_char() to use ASCII-only case-folding rules where appropr - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix to_char() to use ASCII-only case-folding rules where appropr
Date
Msg-id E1UCwCq-0001U9-E2@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix to_char() to use ASCII-only case-folding rules where appropriate.

formatting.c used locale-dependent case folding rules in some code paths
where the result isn't supposed to be locale-dependent, for example
to_char(timestamp, 'DAY').  Since the source data is always just ASCII
in these cases, that usually didn't matter ... but it does matter in
Turkish locales, which have unusual treatment of "i" and "I".  To confuse
matters even more, the misbehavior was only visible in UTF8 encoding,
because in single-byte encodings we used pg_toupper/pg_tolower which
don't have locale-specific behavior for ASCII characters.  Fix by providing
intentionally ASCII-only case-folding functions and using these where
appropriate.  Per bug #7913 from Adnan Dursun.  Back-patch to all active
branches, since it's been like this for a long time.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/81e2255fc77a273c8de41fca73741ceac6b75288

Modified Files
--------------
src/backend/utils/adt/formatting.c |  170 ++++++++++++++++++++++++-----------
src/include/utils/formatting.h     |    4 +
2 files changed, 120 insertions(+), 54 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix to_char() to use ASCII-only case-folding rules where appropr
Next
From: Tom Lane
Date:
Subject: pgsql: Fix to_char() to use ASCII-only case-folding rules where appropr