pgsql: Prevent failure when RowExpr or XmlExpr is parse-analyzed twice. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
Date
Msg-id E1TmquW-0003a1-7G@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.

transformExpr() is required to cope with already-transformed expression
trees, for various ugly-but-not-quite-worth-cleaning-up reasons.  However,
some of its newer subroutines hadn't gotten the memo.  This accounts for
bug #7763 from Norbert Buchmuller: transformRowExpr() was overwriting the
previously determined type of a RowExpr during CREATE TABLE LIKE INCLUDING
INDEXES.  Additional investigation showed that transformXmlExpr had the
same kind of problem, but all the other cases seem to be safe.

Andres Freund and Tom Lane

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/de4cf42af954a03957d3fd7afc1314b45af786e8

Modified Files
--------------
src/backend/parser/gram.y       |    1 +
src/backend/parser/parse_expr.c |   19 +++++++++++++++++--
src/include/nodes/primnodes.h   |    3 ++-
3 files changed, 20 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Prevent failure when RowExpr or XmlExpr is parse-analyzed twice.
Next
From: Robert Haas
Date:
Subject: pgsql: Adjust many backend functions to return OID rather than void.