pgsql: Fix WaitLatch() to return promptly when the requested timeout ex - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix WaitLatch() to return promptly when the requested timeout ex
Date
Msg-id E1TWd1t-0008Rr-Oy@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix WaitLatch() to return promptly when the requested timeout expires.

If the sleep is interrupted by a signal, we must recompute the remaining
time to wait; otherwise, a steady stream of non-wait-terminating interrupts
could delay return from WaitLatch indefinitely.  This has been shown to be
a problem for the autovacuum launcher, and there may well be other places
now or in the future with similar issues.  So we'd better make the function
robust, even though this'll add at least one gettimeofday call per wait.

Back-patch to 9.2.  We might eventually need to fix 9.1 as well, but the
code is quite different there, and the usage of WaitLatch in 9.1 is so
limited that it's not clearly important to do so.

Reported and diagnosed by Jeff Janes, though I rewrote his patch rather
heavily.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/3e7fdcffd6f77187b72b0496d61d782932973af6

Modified Files
--------------
src/backend/port/unix_latch.c  |  196 ++++++++++++++++++++++++----------------
src/backend/port/win32_latch.c |   37 +++++++--
src/include/storage/latch.h    |   13 ++--
3 files changed, 156 insertions(+), 90 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix WaitLatch() to return promptly when the requested timeout ex
Next
From: Peter Eisentraut
Date:
Subject: pgsql: XSLT stylesheet: Add slash to directory name