pgsql: Create an improved FDW option validator function for contrib/dbl - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Create an improved FDW option validator function for contrib/dbl
Date
Msg-id E1TM3HW-00056G-Q8@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Create an improved FDW option validator function for contrib/dbl
List pgsql-committers
Create an improved FDW option validator function for contrib/dblink.

dblink now has its own validator function dblink_fdw_validator(), which is
better than the core function postgresql_fdw_validator() because it gets
the list of legal options from libpq instead of having a hard-wired list.

Make the dblink extension module provide a standard foreign data wrapper
dblink_fdw that encapsulates use of this validator, and recommend use of
that wrapper instead of making up wrappers on the fly.

Unfortunately, because ad-hoc wrappers *were* recommended practice
previously, it's not clear when we can get rid of postgresql_fdw_validator
without causing upgrade problems.  But this is a step in the right
direction.

Shigeru Hanada, reviewed by KaiGai Kohei

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8255566f9d479fdfeea09da3141d26afdbb5abe2

Modified Files
--------------
contrib/dblink/Makefile             |    2 +-
contrib/dblink/dblink--1.0--1.1.sql |   14 ++
contrib/dblink/dblink--1.0.sql      |  223 ---------------------------------
contrib/dblink/dblink--1.1.sql      |  235 +++++++++++++++++++++++++++++++++++
contrib/dblink/dblink.c             |  130 +++++++++++++++++++
contrib/dblink/dblink.control       |    2 +-
contrib/dblink/dblink.h             |    1 +
contrib/dblink/expected/dblink.out  |   17 ++-
contrib/dblink/sql/dblink.sql       |   13 ++-
doc/src/sgml/dblink.sgml            |   12 +--
10 files changed, 410 insertions(+), 239 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Update obsolete text in fdwhandler.sgml.
Next
From: Tom Lane
Date:
Subject: pgsql: Update obsolete comment.