pgAdmin III commit: Fix freeze of UI when querytool has an error on a q - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject pgAdmin III commit: Fix freeze of UI when querytool has an error on a q
Date
Msg-id E1Sq1je-000896-Se@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Fix freeze of UI when querytool has an error on a query

We call too many times the GetCharAt() and the GetText().Length() methods.
This fix calls GetCharAt() once per loop (instead of five times per loop), and
GetText().Length() once only (instead of once per loop). My testing shows no
freeze at all with a 4000 lines of SQL code.

Report per Evan Martin.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=525e7f51434bd52716c0a4fb655e3038a21ef457

Modified Files
--------------
pgadmin/frm/frmQuery.cpp |   13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)


pgadmin-hackers by date:

Previous
From: Vinicius Santos
Date:
Subject: Re: More information about the selected objects
Next
From: Guillaume Lelarge
Date:
Subject: pgAdmin III commit: Fix freeze of UI when querytool has an error on a q