pgsql: Cope with smaller-than-normal BLCKSZ setting in SPGiST indexes o - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Cope with smaller-than-normal BLCKSZ setting in SPGiST indexes o
Date
Msg-id E1Sjacw-0001lm-An@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Cope with smaller-than-normal BLCKSZ setting in SPGiST indexes on text.

The original coding failed miserably for BLCKSZ of 4K or less, as reported
by Josh Kupershmidt.  With the present design for text indexes, a given
inner tuple could have up to 256 labels (requiring either 3K or 4K bytes
depending on MAXALIGN), which means that we can't positively guarantee no
failures for smaller blocksizes.  But we can at least make it behave sanely
so long as there are few enough labels to fit on a page.  Considering that
btree is also more prone to "index tuple too large" failures when BLCKSZ is
small, it's not clear that we should expend more work than this on this
case.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/757773602c424b1e51c2d9cad8a59398ba7f7b2c

Modified Files
--------------
src/backend/access/spgist/spgtextproc.c |   12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Make DROP FUNCTION hint more informative.
Next
From: Robert Haas
Date:
Subject: pgsql: When LWLOCK_STATS is defined, count spindelays.