pgsql: Adjust join_search_one_level's handling of clauseless joins. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Adjust join_search_one_level's handling of clauseless joins.
Date
Msg-id E1SLNvY-000400-72@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Adjust join_search_one_level's handling of clauseless joins.

For an initial relation that lacks any join clauses (that is, it has to be
cartesian-product-joined to the rest of the query), we considered only
cartesian joins with initial rels appearing later in the initial-relations
list.  This creates an undesirable dependency on FROM-list order.  We would
never fail to find a plan, but perhaps we might not find the best available
plan.  Noted while discussing the logic with Amit Kapila.

Improve the comments a bit in this area, too.

Arguably this is a bug fix, but given the lack of complaints from the
field I'll refrain from back-patching.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/1f0363001166ef6a43619846e44cfb9dbe7335ed

Modified Files
--------------
src/backend/optimizer/path/joinrels.c |   46 +++++++++++++++++++-------------
1 files changed, 27 insertions(+), 19 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Revise parameterized-path mechanism to fix assorted issues.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Recast "ONLY" column CHECK constraints as NO INHERIT