pgsql: Fix dblink's failure to report correct connection name in error - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix dblink's failure to report correct connection name in error
Date
Msg-id E1SDNHM-0003xm-6u@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix dblink's failure to report correct connection name in error messages.

The DBLINK_GET_CONN and DBLINK_GET_NAMED_CONN macros did not set the
surrounding function's conname variable, causing errors to be incorrectly
reported as having occurred on the "unnamed" connection in some cases.
This bug was actually visible in two cases in the regression tests,
but apparently whoever added those cases wasn't paying attention.

Noted by Kyotaro Horiguchi, though this is different from his proposed
patch.

Back-patch to 8.4; 8.3 does not have the same type of error reporting
so the patch is not relevant.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/6205bb6e2875514c191370f22f1e10184b655fc5

Modified Files
--------------
contrib/dblink/dblink.c            |   12 +++++++++---
contrib/dblink/expected/dblink.out |    4 ++--
2 files changed, 11 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix dblink's failure to report correct connection name in error
Next
From: Tom Lane
Date:
Subject: pgsql: Fix dblink's failure to report correct connection name in error