pgsql: Fix brain fade in previous pg_dump patch. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix brain fade in previous pg_dump patch.
Date
Msg-id E1RvvrK-0008BL-Lg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix brain fade in previous pg_dump patch.

In pre-7.3 databases, pg_attribute.attislocal doesn't exist.  The easiest
way to make sure the new inheritance logic behaves sanely is to assume it's
TRUE, not FALSE.  This will result in printing child columns even when
they're not really needed.  We could work harder at trying to reconstruct a
value for attislocal, but there is little evidence that anyone still cares
about dumping from such old versions, so just do the minimum necessary to
have a valid dump.

I had this correct in the original draft of the patch, but for some
unaccountable reason decided it wasn't necessary to change the value.
Testing against an old server shows otherwise...

Branch
------
REL8_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/01f99e2d20f7327c213bf5b1f332d62f6590ba5e

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |    6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix brain fade in previous pg_dump patch.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix oversight in pg_dump's handling of extension configuration t