pgsql: When building with LWLOCK_STATS, initialize the stats in LWLockW - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: When building with LWLOCK_STATS, initialize the stats in LWLockW
Date
Msg-id E1RugCf-0001l6-F8@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
When building with LWLOCK_STATS, initialize the stats in LWLockWaitUntilFree.

If LWLockWaitUntilFree was called before the first LWLockAcquire call, you
would either crash because of access to uninitialized array or account the
acquisition incorrectly. LWLockConditionalAcquire doesn't have this problem
because it doesn't update the lwlock stats.

In practice, this never happens because there is no codepath where you would
call LWLockWaitUntilfree before LWLockAcquire after a new process is
launched. But that's just accidental, there's no guarantee that that's
always going to be true in the future.

Spotted by Jeff Janes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/15ad6f1510f8979a39e4c39078c742b5fdb121ce

Modified Files
--------------
src/backend/storage/lmgr/lwlock.c |   33 +++++++++++++++++++++++----------
1 files changed, 23 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix postmaster to attempt restart after a hot-standby crash.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: createuser: Disable prompting by default