pgsql: Fix assorted bogosities in cash_in() and cash_out(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix assorted bogosities in cash_in() and cash_out().
Date
Msg-id E1RKDhb-00059Q-Rt@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix assorted bogosities in cash_in() and cash_out().

cash_out failed to handle multiple-byte thousands separators, as per bug
#6277 from Alexander Law.  In addition, cash_in didn't handle that either,
nor could it handle multiple-byte positive_sign.  Both routines failed to
support multiple-byte mon_decimal_point, which I did not think was worth
changing, but at least now they check for the possibility and fall back to
using '.' rather than emitting invalid output.  Also, make cash_in handle
trailing negative signs, which formerly it would reject.  Since cash_out
generates trailing negative signs whenever the locale tells it to, this
last omission represents a fail-to-reload-dumped-data bug.  IMO that
justifies patching this all the way back.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/7609239f3e8d1cf8818c186c0cfa39145bf6425a

Modified Files
--------------
src/backend/utils/adt/cash.c |  204 ++++++++++++++++++++++-------------------
1 files changed, 109 insertions(+), 95 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix assorted bogosities in cash_in() and cash_out().
Next
From: Robert Haas
Date:
Subject: pgsql: Update visibilitymap.c header comments.