pgsql: Improve libpq's error reporting for SSL failures. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Improve libpq's error reporting for SSL failures.
Date
Msg-id E1Ql5JC-0007bz-J9@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve libpq's error reporting for SSL failures.

In many cases, pqsecure_read/pqsecure_write set up useful error messages,
which were then overwritten with useless ones by their callers.  Fix this
by defining the responsibility to set an error message to be entirely that
of the lower-level function when using SSL.

Back-patch to 8.3; the code is too different in 8.2 to be worth the
trouble.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/276164125c801117a1237043b1212878e1a9bac2

Modified Files
--------------
src/interfaces/libpq/fe-misc.c   |   24 ++++++++++----
src/interfaces/libpq/fe-secure.c |   61 +++++++++++++++++++++++++++++++-------
2 files changed, 67 insertions(+), 18 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Improve libpq's error reporting for SSL failures.
Next
From: Andrew Dunstan
Date:
Subject: Re: pgsql: Improve libpq's error reporting for SSL failures.