pgsql: Refrain from canonicalizing a client_encoding setting of "UNICOD - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Refrain from canonicalizing a client_encoding setting of "UNICOD
Date
Msg-id E1QCDkP-0007YE-P4@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Refrain from canonicalizing a client_encoding setting of "UNICODE".

While "UTF8" is the correct name for this encoding, existing JDBC drivers
expect that if they send "UNICODE" it will read back the same way; they
fail with an opaque "Protocol error" complaint if not.  This will be fixed
in the 9.1 drivers, but until older drivers are no longer in use in the
wild, we'd better leave "UNICODE" alone.  Continue to canonicalize all
other inputs.  Per report from Steve Singer and subsequent discussion.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/390cf3209b718382c0ec9793b714422189e9b68b

Modified Files
--------------
src/backend/commands/variable.c |   30 ++++++++++++++++++++++++------
1 files changed, 24 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Andrew Dunstan
Date:
Subject: pgsql: Silence compiler warning about casting HANDLE to long on WIN64.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Avoid unused variable warnings for certain configurations