pgsql: Move call to GetTopTransactionId() earlier in LockAcquire(), - Mailing list pgsql-committers

From Simon Riggs
Subject pgsql: Move call to GetTopTransactionId() earlier in LockAcquire(),
Date
Msg-id E1PMsFp-00032p-BX@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Move call to GetTopTransactionId() earlier in LockAcquire(),
removing an infrequently occurring race condition in Hot Standby.
An xid must be assigned before a lock appears in shared memory,
rather than immediately after, else GetRunningTransactionLocks()
may see InvalidTransactionId, causing assertion failures during
lock processing on standby.

Bug report and diagnosis by Fujii Masao, fix by me.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=ed78384acd691e3336e170aa18af69d15d088027

Modified Files
--------------
src/backend/storage/ipc/standby.c |   29 +++++++++++++++++++++--------
src/backend/storage/lmgr/lock.c   |   29 +++++++++++++++++++++--------
src/include/storage/standby.h     |    1 +
3 files changed, 43 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Thom Brown
Date:
Subject: Re: pgsql: Add index entries for more functions
Next
From: Simon Riggs
Date:
Subject: pgsql: Move call to GetTopTransactionId() earlier in LockAcquire(),