Re: LLVM breakage on seawasp - Mailing list pgsql-hackers

From Andres Freund
Subject Re: LLVM breakage on seawasp
Date
Msg-id E1E79D92-5993-4B7B-A14B-860392DE625F@anarazel.de
Whole thread Raw
In response to Re: LLVM breakage on seawasp  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: LLVM breakage on seawasp  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On August 24, 2019 1:57:56 PM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> On August 24, 2019 1:08:11 PM PDT, Thomas Munro
><thomas.munro@gmail.com> wrote:
>>> That's because they just moved to C++14 and replaced their own
>>> llvm::make_unique<> with std::make_unique<>:
>>>
>https://github.com/llvm-mirror/llvm/commit/114087caa6f95b526861c3af94b3093d9444c57b
>>> Perhaps we'll need some macrology to select between llvm and std
>>> versions?  I am guessing we can't decree that PostgreSQL's minimum
>C++
>>> level is C++14 and simply change it to std::make_unique.
>
>So we're depending on APIs that upstream doesn't think are stable?

 Seawasp iirc builds against the development branch of llvm, which explains why we see failures there. Does that
addresswhat you are concerned about? If not, could you expand? 

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: LLVM breakage on seawasp
Next
From: Thomas Munro
Date:
Subject: Re: LLVM breakage on seawasp