Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: pg_rewind: Fetch small files according to new size. - Mailing list pgsql-committers

From Daniel Gustafsson
Subject Re: pgsql: pg_rewind: Fetch small files according to new size.
Date
Msg-id DD4C6941-32A6-4819-A867-723CB6D7E1D1@yesql.se
Whole thread Raw
In response to pgsql: pg_rewind: Fetch small files according to new size.  (Daniel Gustafsson <dgustafsson@postgresql.org>)
List pgsql-committers
Tree view 
> On 6 Apr 2022, at 10:44, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> Hmm, it is typical to cast file sizes to long long and print with %lld.
> See d914eb347fcd for a recent example.
>
> .. oh, I see you pushed already.  Not sure this is worth fixing, since
> the original commit message claimed to involve only "small files".

The logic is only effective against files smaller than MAX_CHUNK_SIZE which is
1Mb.  I should've mentioned that in the fixup commit message, sorry for being
vague.

--
Daniel Gustafsson        https://vmware.com/

pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: pgsql: pg_rewind: Fetch small files according to new size.
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Reduce running time of jsonb_sqljson test