Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL - Mailing list pgsql-bugs

From Robin Haberkorn
Subject Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL
Date
Msg-id DB6KVQ60OJ8X.A8LWANY82NLG@b1-systems.de
Whole thread Raw
In response to Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL  (Michael Paquier <michael@paquier.xyz>)
List pgsql-bugs
Hello Michael!

On Sun Jun 8, 2025 at 05:19:29 GMT +03, Michael Paquier wrote:
> I have updated the patches with the attached, splitting the parts for
> contrib/xml2/ and the backend into two parts.  These touch error paths
> that are very unlikely going to be hit in practice, so let's do all
> that once v19 opens for business only on HEAD.

I know this has already been committed, but why are we still using
PG_XML_STRICTNESS_LEGACY in xpath.c? As we are always checking
pg_xml_error_occurred() this should no longer be necessary.

It's of course also still in xslt_proc.c, but I have submitted a
separate patch to the ongoing Commitfest, which will resolve that. [1]

Best regards,
Robin Haberkorn

[1] https://commitfest.postgresql.org/patch/5718/
btw. it's still looking for a rewiever.

--
Robin Haberkorn
Software Engineer

B1 Systems GmbH
Osterfeldstraße 7 / 85088 Vohburg / https://www.b1-systems.de
GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt, HRB 3537



pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #18981: Fault tolerance and improvement for xmltotext_with_options (xml.c)
Next
From: Fujii Masao
Date:
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"