Re: On login trigger: take three - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: On login trigger: take three
Date
Msg-id D919E528-FA84-4094-9468-E53DB27CF4BB@yesql.se
Whole thread Raw
In response to Re: On login trigger: take three  (Andres Freund <andres@anarazel.de>)
Responses Re: On login trigger: take three  (a.sokolov@postgrespro.ru)
Re: On login trigger: take three  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> On 14 Mar 2022, at 17:10, Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2022-03-14 14:47:09 +0100, Daniel Gustafsson wrote:
>>> On 14 Mar 2022, at 01:08, Andres Freund <andres@anarazel.de> wrote:
>>
>>> I was thinking that the way to use it would be to specify it as a client
>>> option. Like PGOPTIONS='-c ignore_event_trigger=login' psql.
>>
>> Attached is a quick PoC/sketch of such a patch, where 0001 adds a guc, 0002 is
>> the previously posted v25 login event trigger patch, and 0003 adapts is to
>> allow ignoring it (0002/0003 split only for illustrative purposes of course).
>> Is this along the lines of what you were thinking?
>
> Yes.
>
> Of course there's still the bogus cache invalidation stuff etc that I
> commented on upthread.

Yeah, that was the previously posted v25 from the author (who adopted it from
the original author).  I took the liberty to quickly poke at the review
comments you had left as well as the ones that I had found to try and progress
the patch.  0001 should really go in it's own thread though to not hide it from
anyone interested who isn't looking at this thread.

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: [PATCH] pgbench: add multiconnect option
Next
From: Mark Dilger
Date:
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs