Re: BUG #18871: Cross-partition MERGE fails with unclear internal error - Mailing list pgsql-bugs

From Gurjeet Singh
Subject Re: BUG #18871: Cross-partition MERGE fails with unclear internal error
Date
Msg-id D8SIN5I77I7S.4YF5B429CIGO@singh.im
Whole thread Raw
In response to Re: BUG #18871: Cross-partition MERGE fails with unclear internal error  (Tender Wang <tndrwang@gmail.com>)
Responses Re: BUG #18871: Cross-partition MERGE fails with unclear internal error
List pgsql-bugs
On Fri Mar 28, 2025 at 7:39 PM PDT, Tender Wang wrote:

> In ExecInitPartitionInfo(), it has comments like:
>
> * This duplicates much of the logic in ExecInitMerge(), so something
> * changes there, look here too.
>
> ExecInitMerge() considers CMD_NOTHING operation.
> I give the attached fix.

I would've expecetd the comment to be in ExecInitMerge(), asking the
reader to look at other places the logic is duplicated.

Attached is a patch with an attempt at that; it includes the diff from
your patch, too, so I named it v2.

Best regards,
Gurjeet
http://Gurje.et

Attachment

pgsql-bugs by date:

Previous
From: Tender Wang
Date:
Subject: Re: BUG #18871: Cross-partition MERGE fails with unclear internal error
Next
From: Dean Rasheed
Date:
Subject: Re: BUG #18871: Cross-partition MERGE fails with unclear internal error